Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eks-prow-build-cluster: create simple monitoring stack #5011

Merged
merged 9 commits into from
Mar 27, 2023
Merged

eks-prow-build-cluster: create simple monitoring stack #5011

merged 9 commits into from
Mar 27, 2023

Conversation

pkprzekwas
Copy link
Contributor

@pkprzekwas pkprzekwas commented Mar 23, 2023 •
edited
Loading

This PR brings simple monitoring setup for Prow EKS cluster. At some point we will replace it with sth more sophisticated (like kube-prometheus). For now, in order to debug migration of prow jobs, this is hopefully enough.

PR contains:

  • dedicated monitoring namespace
  • prometheus operator
  • single prometheus instance (if we want to access its metrics externally we can consider switching this instance into agent mode and pushing metics to AWS Managed Prometheus instance)
  • kube-state-metrics
  • node-exporter
  • cadvisor
  • internal grafana instance (meaning that's it not exposed neither secured)

/assign @ameukam @upodroid @xmudrii
This stack has been already deployed to prow-build-cluster. Part of #4686

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 23, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: pkprzekwas / name: pprzekwas (c93edaa)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ labels Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @pkprzekwas!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @pkprzekwas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Mar 23, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 23, 2023
@xmudrii
Copy link
Member

xmudrii commented Mar 23, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2023
@pkprzekwas pkprzekwas changed the title Create simple monitoring stack for EKS prow cluster eks-prow-build-cluster: create simple monitoring stack Mar 24, 2023
@pkprzekwas
Copy link
Contributor Author

On top of that I've tested the AWS native Container Insights. Installation is trivial but it requires modifying terraform script in order to extend permissions of instance profiles. At the moment any modifications to EKS terraform script are blocked by #4989. Once it's merged, Container Insights can be enabled in a separate PR.

xmudrii
xmudrii reviewed Mar 25, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks pretty good to me. I left some questions and comments, most of them should be just nits.

infra/aws/terraform/prow-build-cluster/resources/monitoring/README.md
kubectl --namespace monitoring port-forward svc/prometheus-operated 9090

# Grafana
kubectl --namespace monitoring port-forward svc/grafana 3000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we expose this Grafana instance publicly? If yes, let's create a follow up issue to track that.

Copy link
Contributor Author

@pkprzekwas pkprzekwas Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if this is something that we want to maintain in a longer term. IMO we can expose it for now till we haven't figured which monitoring solution works the best for both GCP and AWS clusters.

I wonder if there were other things we want to expose over time, in which case ingress-controller would be handy.

infra/aws/terraform/prow-build-cluster/resources/README.md Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/cadvisor/cluster-role.yaml Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/cadvisor/ds.yaml Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/grafana/datasources.yaml Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/node-exporter/cluster-role.yaml Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/node-exporter/ds.yaml Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/node-exporter/service-monitor.yaml Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/prometheus-main/sa.yaml Outdated Show resolved Hide resolved
infra/aws/terraform/prow-build-cluster/resources/monitoring/grafana/config.yaml Show resolved Hide resolved
@pkprzekwas pkprzekwas requested a review from xmudrii March 27, 2023 08:56
xmudrii
xmudrii approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!
/lgtm
/approve
/assign @ameukam
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@ameukam
Copy link
Member

ameukam commented Mar 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, pkprzekwas, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit e9a97aa into kubernetes:main Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Mar 27, 2023
@pkprzekwas pkprzekwas mentioned this pull request Mar 27, 2023
Closed
9 tasks
@pkprzekwas pkprzekwas deleted the basic-eks-monitoring branch July 6, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@ameukam ameukam

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@pkprzekwas @k8s-ci-robot @xmudrii @ameukam